feat(hooks): add job descriptions, skip descriptions, and OS/arch conditions#248
Merged
feat(hooks): add job descriptions, skip descriptions, and OS/arch conditions#248
Conversation
…ditions Add `description` field to jobs for human-readable context shown in dry-run output and shell completions. Add `desc` field to skip/only structured rules to override auto-generated skip reasons. Add `os` and `arch` fields to jobs for platform-based conditional execution. Also adds `--verbose` flag to `hooks run` to show skipped jobs with reasons, and updates zsh/fish/bash completions to display job descriptions. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Skipped jobs were incorrectly rendered as successful: they showed a spinner, printed "No output", and appeared in the summary with a green checkmark. This was misleading when jobs were skipped due to skip/only conditions. Changes: - Add SkipInfo struct to conditions.rs that tracks whether a skip check ran a command (ran_command: true for `run` checks, false for ref/env) - Add skip_ran_command field to HookResult and skipped_after_command() constructor to propagate this information - Update finish_job_skipped() to always print a single inline line with yellow reason text and no blank line after (not gated on verbose) - Add skipped jobs to the summary with ⊘ icon in yellow, with conditional duration display based on whether a command was run - Fix DAG parallel executor which incorrectly called finish_job_success for skipped jobs instead of finish_job_skipped - Replace JobResultEntry.success bool with JobOutcome enum (Success/Failed/Skipped) for richer summary rendering Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Move `PATH_add ./target/release` from `.envrc` to `mise.toml`'s `_.path` config, eliminating the direnv dependency. Remove the `direnv allow` and `direnv revoke` hooks from `daft.yml` since mise handles environment activation automatically via `mise trust`. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
descriptionfield for hook jobs, shown in progress output for better UXdescfield for skip conditions, shown when a job is skippedosandarchconditions for platform-specific job executionhooks runcommand_.pathinmise.toml)Fixes #246
Test plan
mise run test:unit)daft hooks run post-cloneon macOS./target/releaseis on PATH via mise (no direnv needed)🤖 Generated with Claude Code