fix(hooks): resolve hooks not executing on first run after upgrade#259
Merged
fix(hooks): resolve hooks not executing on first run after upgrade#259
Conversation
Replace private resolve_git_dir() with get_git_common_dir() from repo.rs which canonicalizes the path. Without canonicalization, trust DB lookups fail on systems with symlinks (e.g. macOS /var -> /private/var), causing hooks to be silently skipped after install/upgrade. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
CommandBridge::run_hook() was reading result.stderr instead of result.skip_reason, losing the actual reason hooks were skipped (e.g., "Repository not trusted"). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Previously only clone and flow-adopt showed a notice when hooks were skipped due to trust. Now go/start also inform the user how to enable hooks with `git daft hooks trust`. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolve_git_dir()withget_git_common_dir()fromrepo.rswhich canonicalizes paths, fixing trust DB lookups on systems with symlinks (e.g. macOS/var->/private/var)CommandBridge::run_hook()propagatingresult.stderrinstead ofresult.skip_reason, which lost the actual skip reasongo/startcommands (previously onlycloneandadoptshowed it)Test Plan
mise run clippy— zero warningsmise run fmt— cleanmise run test:unit— 6/6 passedmise run test:integration— 198/198 passed (default + gitoxide backends)🤖 Generated with Claude Code