Skip to content

fix(sync): refresh remote tracking info after push in TUI output#297

Merged
avihut merged 1 commit intomasterfrom
fix/misaligned-sync-end-reported-values
Mar 13, 2026
Merged

fix(sync): refresh remote tracking info after push in TUI output#297
avihut merged 1 commit intomasterfrom
fix/misaligned-sync-end-reported-values

Conversation

@avihut
Copy link
Owner

@avihut avihut commented Mar 13, 2026

Summary

  • After a successful push, the sync TUI displayed stale pre-push remote ahead/behind values (e.g., ⇡14 ⇣13) because the Push task handler returned None for updated_info
  • Added refresh_dynamic_fields() call after successful push, matching the existing pattern used by Update and Rebase task handlers

Test plan

  • Run daft sync --push --force-with-lease on a branch with pending pushes and verify the end-of-sync status shows correct (empty) remote values
  • Run daft list immediately after and confirm values match the sync output
  • Verify failed pushes still show correct status (no refresh on failure)

🤖 Generated with Claude Code

The sync TUI displayed stale pre-push remote ahead/behind values because
the Push task handler returned None for updated_info. The Update and
Rebase handlers both call refresh_dynamic_fields() after success, but
Push did not. This caused the end-of-sync status to show values like
⇡14 ⇣13 even though the push had already completed.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@avihut avihut modified the milestones: Standalone daft, v1.1.0 Mar 13, 2026
@avihut avihut added the fix Bug fix label Mar 13, 2026
@avihut avihut self-assigned this Mar 13, 2026
@avihut avihut merged commit ff81098 into master Mar 13, 2026
6 checks passed
@avihut avihut deleted the fix/misaligned-sync-end-reported-values branch March 13, 2026 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant