Skip to content

fix: add missing completions for top-level flags#311

Merged
avihut merged 1 commit intomasterfrom
fix/missing-completions-for-top-level-flags
Mar 16, 2026
Merged

fix: add missing completions for top-level flags#311
avihut merged 1 commit intomasterfrom
fix/missing-completions-for-top-level-flags

Conversation

@avihut
Copy link
Owner

@avihut avihut commented Mar 16, 2026

Summary

  • Add --version/-V and --help/-h flag completions to the top-level daft command in bash, zsh, and fish shell completion scripts
  • Previously only subcommands were completed; the fig spec already had these flags

Test plan

  • mise run fmt — passes
  • mise run clippy — passes, zero warnings
  • mise run test:unit — all 656 tests pass
  • Verified completion output for all three shells includes the new flags

🤖 Generated with Claude Code

…command

The bash, zsh, and fish completion scripts only completed subcommands
at the top level, missing the --version/-V and --help/-h flags that
the daft binary supports. The fig spec already had them.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@avihut avihut added this to the Public Launch milestone Mar 16, 2026
@avihut avihut added the fix Bug fix label Mar 16, 2026
@avihut avihut self-assigned this Mar 16, 2026
@avihut avihut merged commit ab28879 into master Mar 16, 2026
8 checks passed
@avihut avihut deleted the fix/missing-completions-for-top-level-flags branch March 16, 2026 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant