fix(hooks): skip prompt when trust level unchanged#371
Merged
Conversation
Running `daft hooks trust` or `daft hooks prompt` against a repo already at the target level now prints "already at <level>, nothing to do." and returns without prompting or writing to the trust database. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
avihut
force-pushed
the
fix/dont-prompt-hooks-with-no-change
branch
from
b2606c1 to
66960c3
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
daft hooks trustanddaft hooks promptnow short-circuit when thetarget level matches the current level, printing
Trust: already at <level>, nothing to do.and returning without aconfirmation prompt or trust-database write.
cmd_set_trustinsrc/commands/hooks/trust.rs,before any prompt logic, so it applies with or without
--force.cmd_denyalready handles the equivalent no-op viahas_explicit_trust.Test plan
mise run fmtmise run clippymise run test:manual -- --ci hooks:trust-noop— new regressionscenario runs
daft hooks trusttwice anddaft hooks prompttwice,asserting that the second invocation exits 0 and contains
"already at" / "nothing to do" without blocking on stdin.
🤖 Generated with Claude Code