fix(exec): center header, fix stuck timer, brighten command preview#404
Merged
fix(exec): center header, fix stuck timer, brighten command preview#404
Conversation
Three fixes to the live UI of `daft exec` against multiple worktrees: * **Header centering** — the scope-summary line previously used a fixed 8-char prefix, leaving the summary visibly left-of-center. Balance prefix/suffix dashes so the summary sits in the middle of the 60-column divider. * **Stuck spinner timer** — the elapsed-time suffix was promoted onto the spinner only inside `update_job_output`, so a long-running silent job (`Compiling daft …` for tens of seconds with no fresh stdout) never received the `[HH:MM:SS]` suffix. Drive the promotion from a one-shot per-job thread that fires on a wall-clock deadline. * **Readable command preview** — the in-flight `❯ <cmd>` rendered in DARK_GREY (palette 240), which is barely distinguishable from the background on dark themes. Drop the color so it matches the post-run rows, which also use the default foreground. Adds regression tests for the centering math and the wall-clock promotion. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three rendering fixes to the live UI of
daft execagainst multiple worktrees:update_job_output, so a long-running silent job (Compiling daft …for tens of seconds with no fresh stdout) never received the[HH:MM:SS]suffix. Promotion is now driven by a per-job one-shot thread that fires on a wall-clock deadline.❯ <cmd>rendered in DARK_GREY (palette 240), which is barely distinguishable from the background on dark themes. The color is dropped so the in-flight preview matches the post-run rows, which already use the default foreground.Test plan
mise run fmt:checkmise run clippymise run test:unit— 1179 passedmise run test:manual --ci— 440 scenarios / 1561 steps passedformat_header_linecentering invariant + total-width preservation + overflow-summary fallbacktimer_promotes_on_wall_clock_even_without_output— proves the timer suffix appears even when the job emits no stdout past the thresholddaft exec --all -- mise devagainst ≥2 worktrees on a slow build🤖 Generated with Claude Code