fix: enable CD behavior for all shortcut styles#80
Merged
Conversation
- Add shell wrapper functions for all shortcuts (git, shell, legacy styles) to shell-init output, ensuring CD behavior works regardless of whether users invoke commands via symlinks or shell functions - Automatically install git-style shortcuts during `daft setup` - Show hint about switching to other shortcut styles (shell, legacy) Fixes #79 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
daft shell-initoutputdaft setupProblem
When using shortcut symlinks (
gwtco,gwtcb, etc.), the CD behavior didn't work because symlinks bypass the shell wrapper functions that handle the__DAFT_CD__marker.Solution
Shell wrappers for all shortcuts: Shell functions take precedence over symlinks. By defining wrapper functions for all shortcuts in
daft shell-init, CD behavior now works regardless of how commands are invoked.Auto-install shortcuts:
daft setupnow automatically installs git-style shortcuts, so users get a complete setup in one command.Hint about alternatives: After setup, users see how to switch to other shortcut styles if they prefer.
What users see after
daft setupTest plan
cargo clippy -- -D warningspassescargo fmt -- --checkpassesjust test-unitpasses (97 tests)daft setup, verify shortcuts installed and CD worksRelated
🤖 Generated with Claude Code