Skip to content

add support for previous unsupported special forms#19

Merged
avli merged 1 commit intoavli:masterfrom
fasfsfgs:refactoring-special-forms
Jan 31, 2017
Merged

add support for previous unsupported special forms#19
avli merged 1 commit intoavli:masterfrom
fasfsfgs:refactoring-special-forms

Conversation

@fasfsfgs
Copy link
Copy Markdown
Contributor

Some special forms were left out of #15 because they didn't follow a common pattern as others special forms.
Those are: '.', 'new', 'fn', 'set!'

I added their signature support manually because of one of the reasons below:

  • Their doc-strings were lacking correct info to build a proper signature helper (I based signatures on the online documentation of special forms and java interop);
  • The logic necessary to extract their signature support based on their non-standard doc-strings would be too great for just a couple of cases.

closes #16

@avli
Copy link
Copy Markdown
Owner

avli commented Jan 31, 2017

Hi @fasfsfgs,

Great job as usual. Glad to see you again ;)

@avli avli merged commit edafc7d into avli:master Jan 31, 2017
@fasfsfgs fasfsfgs deleted the refactoring-special-forms branch January 31, 2017 12:49
@fasfsfgs
Copy link
Copy Markdown
Contributor Author

@avli Thanks =D
I wish I had more time to work with this but other stuff comes in the way.
I'll keep helping here as often as I can. =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

support signature helper for '.', 'new', 'fn', 'set!' (unsupported special forms)

2 participants