Added automatic nREPL startup for Windows#55
Merged
avli merged 4 commits intoavli:masterfrom Aug 1, 2017
fachammer:master
Merged
Added automatic nREPL startup for Windows#55avli merged 4 commits intoavli:masterfrom fachammer:master
avli merged 4 commits intoavli:masterfrom
fachammer:master
Conversation
…on to avoid spawn ENOENT error on Windows
Owner
|
Thank you very much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, when opening a .clj file on Windows the nREPL server would not be started automatically because it would throw an error when spawning the lein process.
Apparently spawn behaves a bit differently on Windows. Using the cross-spawn modules gets rid of some of the problems.
However, I also had to remove the detached option for the spawn to work on Windows. Is there a particular reason for having it set to true at all? I tested it on a Fedora-VM and it seemed to work fine without detached being set to true.