python-aexpect.spec: Update spec with latest version #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@clebergnu when you have some time, please update the Fedora packages. I have been doing some package maintenance for Amazon Linux, so I can also help with maintenance in case you want. |
ldoktor
requested changes
Mar 1, 2023
Contributor
ldoktor
left a comment
ldoktor
left a comment
There was a problem hiding this comment.
Hello Lucas, there is one more file to be changed:
diff --git a/Makefile b/Makefile
index 6c2dc73..2fe0ea5 100644
--- a/Makefile
+++ b/Makefile
@@ -3,7 +3,7 @@ PYTHON_DEVELOP_ARGS=$(shell if ($(PYTHON) setup.py develop --help 2>/dev/null |
DESTDIR=/
BUILDIR=$(CURDIR)/debian/aexpect
PROJECT=aexpect
-VERSION="1.6.4"
+VERSION="1.7.0"
COMMIT=$(shell git log --pretty=format:'%H' -n 1)
SHORT_COMMIT=$(shell git log --pretty=format:'%h' -n 1)
COMMIT_DATE=$(shell git log --pretty='format:%cd' --date='format:%Y%m%d' -n 1)
I forgot to make that update when cutting 1.7.0. Signed-off-by: Lucas Meneghel Rodrigues <lmr@amazon.com>
lmr
force-pushed
the
fix/rpm-build-spec-file
branch
from
6ba39e6 to
6184ddb
Compare
Member
Author
|
@ldoktor good point, updated. |
ldoktor
approved these changes
Mar 1, 2023
Contributor
There was a problem hiding this comment.
Thank you, seems to work well although I'm wondering how the make rpm-release will work (maybe a new tag will be required, but IIRC Fedora uses different targets so perhaps it's not necessary; let's wait for @clebergnu or @mmathesius)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forgot to make that update when cutting 1.7.0.