Fix an fstring formatting for the remote linux ops #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Plamen Dimitrov <plamen.dimitrov@intra2net.com>
pevogam
force-pushed
the
linux-ops-fstring
branch
from
9f8ca15 to
e6f8eaa
Compare
Contributor
Author
ldoktor
reviewed
Apr 4, 2025
| and this can lead to false-positives when used inside tests. | ||
| """ | ||
| LOG.info("Replacing {pattern} with {replacement} in {filename}") | ||
| LOG.info("Replacing %s with %s in %s", pattern, replacement, filename) |
Contributor
There was a problem hiding this comment.
Well f-strings are recommended these days so how about adding the f before the string to make it work like a proper f-string?
Contributor
Author
There was a problem hiding this comment.
Yup, this is exactly what I did originally but aexpect has a linter that would fail if one uses fstrings with logging (not the recommended way according to some standards) and all other aexpect logging messages use this formatting (and the linter passes for them) so I settled for what is most compatible with the project code base.
Contributor
There was a problem hiding this comment.
Ah, I didn't noticed. Thanks, then this is definitely better (to log variables in case of msg format error)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.