Skip to content

Conversation

@ldoktor
Copy link
Contributor

@ldoktor ldoktor commented Jul 29, 2025

Fixes: #127

Signed-off-by: Lukáš Doktor <ldoktor@redhat.com>
@ldoktor ldoktor requested a review from lmr July 29, 2025 12:51
@ldoktor
Copy link
Contributor Author

ldoktor commented Jul 30, 2025

@pevogam any objections?

@pevogam
Copy link
Contributor

pevogam commented Jul 30, 2025

None at all 🎉

@ldoktor ldoktor merged commit 9b25ca7 into avocado-framework:main Jul 30, 2025
3 checks passed
@pevogam
Copy link
Contributor

pevogam commented Aug 8, 2025

I am wondering if everything is ok with the release since in one of our CI-s I see this:

 Building wheels for collected packages: aexpect
  Building editable for aexpect (pyproject.toml): started
  Building editable for aexpect (pyproject.toml): finished with status 'done'
  Created wheel for aexpect: filename=aexpect-1.8.0-0.editable-py3-none-any.whl size=12823 sha256=199358c7ef5833d4ead2f0022fb29fd7fcbc82fd11506efbe113b8d990988e40
  Stored in directory: /tmp/pip-ephem-wheel-cache-qf6so415/wheels/f7/d6/6d/8c10e4c5944f7768a448f0d7e7751471e0f52853cf93fadb9e

followed by lots of failing tests like

Failed to load plugin from module "avocado_vt.plugins.vt_list_guests": ModuleNotFoundError("No module named 'pipes'") :
File "/home/runner/work/avocado-i2n/avocado-i2n/avocado-libs/avocado/core/extension_manager.py", line 95, in __init__
  plugin = ep.load()
File "/opt/hostedtoolcache/Python/3.13.5/x64/lib/python3.13/site-packages/pkg_resources/__init__.py", line 2777, in load
  return self.resolve()
         ~~~~~~~~~~~~^^
File "/opt/hostedtoolcache/Python/3.13.5/x64/lib/python3.13/site-packages/pkg_resources/__init__.py", line 2783, in resolve
  module = __import__(self.module_name, fromlist=['__name__'], level=0)
File "/home/runner/work/avocado-i2n/avocado-i2n/avocado-vt-libs/avocado_vt/plugins/vt_list_guests.py", line 7, in <module>
  from ..loader import guest_listing
File "/home/runner/work/avocado-i2n/avocado-i2n/avocado-vt-libs/avocado_vt/loader.py", line 25, in <module>
  from virttest import cartesian_config, data_dir, standalone_test, storage
File "/home/runner/work/avocado-i2n/avocado-i2n/avocado-vt-libs/virttest/storage.py", line 22, in <module>
  from virttest import (
  ...<15 lines>...
  )
File "/home/runner/work/avocado-i2n/avocado-i2n/avocado-vt-libs/virttest/ceph.py", line 17, in <module>
  from virttest import error_context, utils_misc, utils_numeric
File "/home/runner/work/avocado-i2n/avocado-i2n/avocado-vt-libs/virttest/utils_misc.py", line 33, in <module>
  import aexpect
File "/opt/hostedtoolcache/Python/3.13.5/x64/lib/python3.13/site-packages/aexpect/__init__.py", line 35, in <module>
  from . import remote
File "/opt/hostedtoolcache/Python/3.13.5/x64/lib/python3.13/site-packages/aexpect/remote.py", line 50, in <module>
  import pipes
  ```

@pevogam
Copy link
Contributor

pevogam commented Aug 8, 2025

All this happens strictly on Python 3.13 variant, could it be that we produce different wheel for it? I will also investigate some caching issue in https://github.com/pevogam/avocado-i2n/actions/runs/16833894277/job/47688330984 of course.

@pevogam
Copy link
Contributor

pevogam commented Aug 8, 2025

Ah false alarm, this somehow worked before but now pulled the wrong aexpect 1.7.0 which is incompatible with Python 3.13. Sorry for the noise!

@ldoktor
Copy link
Contributor Author

ldoktor commented Aug 13, 2025

Uff, thanks for the confirmation :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Release aexpect 1.7.1

2 participants