chore: fix clippy and cargo-audit failures on stable 1.95#130
Merged
mobileoverlord merged 2 commits intomainfrom Apr 21, 2026
Merged
chore: fix clippy and cargo-audit failures on stable 1.95#130mobileoverlord merged 2 commits intomainfrom
mobileoverlord merged 2 commits intomainfrom
Conversation
fixes two pre-existing clippy issues that fail ci on rust 1.95's stricter lint set: - collapsible_if in disk_writer.rs (1.92+) - collapsible_match in tui/renderer.rs (1.95+) both were already on main but its clippy workflow only runs on PRs, so they hadn't been caught until now.
cargo update -p rustls-webpki only — patched version pulls via the existing version constraint. no cargo.toml change needed. - rustsec-2026-0098: name constraints for uri names were incorrectly accepted - rustsec-2026-0099: name constraints accepted for certs asserting a wildcard name rustls-webpki is a transitive dep through reqwest and tough.
2 tasks
mobileoverlord
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
collapsible_ifindisk_writer.rs,collapsible_matchintui/renderer.rs)rustls-webpkito 0.103.12 for RUSTSEC-2026-0098 and RUSTSEC-2026-0099 (cargo update -p rustls-webpkionly — no Cargo.toml change)Both issues are latent on
main; CI doesn't run clippy or cargo-audit on scheduled workflows, so they first surface on PRs.Test plan
cargo clippy --all-targets --all-features -- -D warningsclean on stable 1.95cargo auditclean (2 informational warnings remain forrand, not blocking)cargo test --libpasses