recognize iterable type by constructor reference for serialization #12
Conversation
src/serialize.js
Outdated
| return 'Map' | ||
| } | ||
|
|
||
| if (iterable.constructor === immutable.OrderedMap) { |
There was a problem hiding this comment.
Nechceš to spíš udělat jako switch (iterable.constructor), aby to bylo kompaktnější?
There was a problem hiding this comment.
jo sem kkt, switch tam dám.
| debug('replaceIterable()', iter) | ||
|
|
||
| const iterableType = iter.constructor.name | ||
| const iterableType = getIterableType(iter) |
There was a problem hiding this comment.
To se klidně mohl jen upravit ten switch tady.
There was a problem hiding this comment.
no já potřebuju ten string pro tu serializaci, takže jsem to udělal přes metodu
There was a problem hiding this comment.
Ach tak, jasně, jsem vůl. Ok.
src/serialize.js
Outdated
| return 'Map' | ||
| } | ||
|
|
||
| if (iterable.constructor === immutable.OrderedMap) { |
There was a problem hiding this comment.
Chtělo by to test na tu serializaci. Asi tak, že bys pro ten test monkey-patchnul immutable.Map.constructor.name, pokud to jde.
There was a problem hiding this comment.
na to tam testy jsou normálně
There was a problem hiding this comment.
Já vim, ale fixujem bug přece. :D
There was a problem hiding this comment.
jo takle myslíš test, jasně
There was a problem hiding this comment.
tak to nejde - cannot assign readonly property name
vojtatranta
force-pushed
the
fix-json-immutable-serialization-in-minified-env
branch
from
e62e0d8 to
2239268
Compare
2 participants
closes #10