build(cli-sidecar): target net10.0 to align with cli-rhino/cli-sketchup (#154)#156
Merged
Conversation
…up (#154) cli-sidecar is an out-of-process tool (metadata reflection + NativeAOT; never loads into a CAD host), so it can track the latest runtime like cli-rhino and cli-sketchup (both net10). Bumps cli-sidecar + its Tests/Generator/FixtureAssembly projects net9.0 → net10.0, and updates every consumer of the build-output path: the release workflow's sidecar publish step, the Ingest extract/regen dev scripts, and the cli-sidecar / wix packaging READMEs. archicad extraction-notes paths too. cli-tekla (net48) and cli-revit (net8) stay pinned — they load in-process against the host runtime. Verified: net10 build + 147 sidecar tests pass locally. Follow-up (separate, via skill-creator): two skill .md files still mention the sidecar targets net9 — tracked as its own task to respect the skill-edit workflow.
…#154 review) A first pass missed several consumers of the sidecar build-output path (my verification grep wrongly filtered any line containing '/bin/'). Updated: - .github/workflows/build-sidecar.yml — smoke-test binary, fixture DLL, artifact upload paths (Codex-flagged: would break the sidecar CI job). - Rust integration tests that resolve the sidecar by path: coverage_e2e, coverage_validate, sidecar_integration (+ its Debug fixture path). - scripts/regen-nuget-agents.py sidecar exe path. - Agent EXTRACTION-NOTES.md run-path examples + cli-sidecar test path comments. Intentionally left: ui-inspector's own runtime-tfm (not the sidecar), the nuget TFM-ranking logic/tests, the AngleSharp comment, historical plan/handoff docs, and the two skill .md mentions (deferred to a skill-creator task).
…view) The sidecar now targets net10.0, but build-sidecar.yml provisioned only dotnet-version 9.0.x, so `dotnet publish cli-sidecar` would fail with NETSDK1045 on a clean runner. Bumped to 10.0.x (the release workflow already installs 10). Found by Codex review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cli-sidecaris an out-of-process tool (metadata reflection viaMetadataLoadContext+ NativeAOT; it never loads into a CAD host), so it can track the latest runtime likecli-rhinoandcli-sketchup(both net10). Closes #154.cli-sidecar+ itsTests,Ingest/Generator/Tests, andFixtureAssemblyprojects net9.0 → net10.0.9.0.x → 10.0.x); the Ingest extract/regen dev scripts;scripts/regen-nuget-agents.py; the cli-sidecar/wix READMEs; Rust integration tests that resolve the sidecar by path (coverage_e2e,coverage_validate,sidecar_integration); agentEXTRACTION-NOTES.mdrun-paths; and cli-sidecar test path comments.cli-tekla(net48) andcli-revit(net8) load in-process against the host runtime. Also left alone: ui-inspector's ownruntime-tfm, the nuget TFM-ranking logic, the AngleSharp comment, and historical plan/handoff docs.Review
Codex (
codex exec review --base main) — 3 rounds, all findings addressed, final pass clean (missed build-sidecar.yml paths + its SDK install version).Test plan
dotnet build cli-sidecarclean (0 warnings),dotnet test cli-sidecar/Tests→ 147 passed, Generator/Tests buildscargo build --testscompiles after the integration-test path editsFollow-up
Two skill
.mdfiles still say the sidecar targets net9 — tracked as a separate task to update via the skill-creator workflow (per CLAUDE.md), not hand-edited here.