chore(cli): clear clippy 1.95.0 lints and make crate fmt-clean#169
Merged
Conversation
Pre-existing failures under the newer toolchain (clippy 1.95.0 / current rustfmt), unrelated to any one feature — `cargo clippy --all-targets -- -D warnings` and `cargo fmt --all --check` both pass now: - key.rs: collapse nested if into a let-chain (collapsible_if) - receipt.rs: drop redundant trim() before split_whitespace (x2); drop unnecessary to_string() before with_extension (&str is AsRef<OsStr>) - main.rs: box the large `Build` subcommand variant (large_enum_variant) - agent.rs (test): iterate map values() instead of (_, v) (for_kv_map) - repo-wide `cargo fmt --all` No behavior change. 502 tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Housekeeping:
cargo clippy --all-targets -- -D warningsandcargo fmt --all --checkwere failing onmainunder the newer toolchain (clippy 1.95.0 / current rustfmt) — pre-existing, unrelated to any one feature. Both pass now.Clippy fixes
commands/key.rs— collapse nestedifinto a let-chain (collapsible_if)receipt.rs— drop redundanttrim()beforesplit_whitespace()(×2); drop unnecessaryto_string()beforewith_extension(&stralreadyAsRef<OsStr>)main.rs— box the largeBuildsubcommand variant (large_enum_variant); supported by the locked clap versionmanifest/agent.rs(test) — iteratemap.values()instead of(_, v)(for_kv_map)Formatting
cargo fmt --allNo behavior change. 502 tests pass; clippy + fmt clean.
Review
codex exec review --base main): no actionable regressions.Test plan
cargo clippy --all-targets -- -D warnings— cleancargo fmt --all --check— cleancargo test— 502 passed, 0 failed