Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a JSON schema validation warning occurring in the Remote Tab when switching the calibration type to RGBCMYK instead of default RGB mode in the Live calibration panel.
The issue was caused by a missing black color field definition in the local API JSON schema. When the user selects the RGBCMYK mode (by disabling RGB Calibration), the API sends a black value that was previously unrecognized, leading to a schema invalid warning ("Errors during specific message validation, please consult the HyperHDR Log") and preventing correct data synchronization. The RGBCMYK color adjustment command via JSON API was also affected when a black color target was specified.