Skip to content

⚡ Bolt: [Reduce GC allocations in active pairing spatial queries using Object Pooling]#69

Merged
awest813 merged 1 commit into
mainfrom
bolt-optimize-cability-active-pairing-2043788448023227089
Mar 25, 2026
Merged

⚡ Bolt: [Reduce GC allocations in active pairing spatial queries using Object Pooling]#69
awest813 merged 1 commit into
mainfrom
bolt-optimize-cability-active-pairing-2043788448023227089

Conversation

@awest813
Copy link
Copy Markdown
Owner

💡 What: Replaced per-call allocations of anonymous CUnitEnumFunction callbacks and Rectangle instances in CAbilityAbilityBuilderActivePairing.findPairUnits with reusable, LibGDX Pool-managed callback implementations and a shared static RECYCLE_RECT.
🎯 Why: To eliminate constant GC overhead that occurs when active pairings continuously query the map to find nearby partners, while preserving complete state safety against simulation re-entrancy bugs.
📊 Impact: Prevents multiple object allocations per unit evaluation in the ability loop, helping to smooth out frame times and reduce GC stutters.
🔬 Measurement: Can be verified by running Java Flight Recorder or any memory profiler to observe reduced allocation rates for CAbilityAbilityBuilderActivePairing$X closures and Rectangle during map interactions with paired abilities. Tests successfully compiled and passed.


PR created automatically by Jules for task 2043788448023227089 started by @awest813

Co-authored-by: awest813 <208855664+awest813@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@awest813 awest813 merged commit 40423dc into main Mar 25, 2026
4 checks passed
@awest813 awest813 deleted the bolt-optimize-cability-active-pairing-2043788448023227089 branch March 25, 2026 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant