⚡ Bolt: [Reduce GC allocations in active pairing spatial queries using Object Pooling]#69
Conversation
Co-authored-by: awest813 <208855664+awest813@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Replaced per-call allocations of anonymous
CUnitEnumFunctioncallbacks andRectangleinstances inCAbilityAbilityBuilderActivePairing.findPairUnitswith reusable, LibGDXPool-managed callback implementations and a shared staticRECYCLE_RECT.🎯 Why: To eliminate constant GC overhead that occurs when active pairings continuously query the map to find nearby partners, while preserving complete state safety against simulation re-entrancy bugs.
📊 Impact: Prevents multiple object allocations per unit evaluation in the ability loop, helping to smooth out frame times and reduce GC stutters.
🔬 Measurement: Can be verified by running Java Flight Recorder or any memory profiler to observe reduced allocation rates for
CAbilityAbilityBuilderActivePairing$Xclosures andRectangleduring map interactions with paired abilities. Tests successfully compiled and passed.PR created automatically by Jules for task 2043788448023227089 started by @awest813