⚡ Bolt: [performance improvement] Optimize spatial query callbacks#73
Conversation
Extracts anonymous CUnitEnumFunction classes in heavily used skills (WarStomp, ThunderClap, Kaboom, AuraBase) into cached inner classes with `reset` methods to eliminate GC allocations during spatial queries. Co-authored-by: awest813 <208855664+awest813@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
💡 What: Extracted anonymous
CUnitEnumFunctioncallbacks used inenumUnitsInRangespatial queries into cached private inner classes withresetmethods across several frequently used ability classes (CAbilityWarStomp,CAbilityThunderClap,CAbilityKaboom,CAbilityAuraBase).🎯 Why: In Java, capturing lambdas and anonymous classes instantiate a new object on the heap every time they are called. For abilities cast frequently, and especially for auras which tick continuously via
onTick(), this creates continuous Garbage Collection (GC) pressure that can cause micro-stutters during gameplay.📊 Impact: Eliminates object allocations per spell cast/aura tick for these abilities, reducing overall GC overhead and improving frame pacing stability.
🔬 Measurement: Run a stress test with multiple Mountain Kings and Tauren Chieftains surrounded by enemies or multiple units with auras and profile memory allocations; observe the reduction in
CUnitEnumFunctionandCAbility...$1allocations.PR created automatically by Jules for task 9835567343069554693 started by @awest813