fix(copilot): add dangerously_skip_permissions alias for --allow-all#338
Merged
Merged
Conversation
- `internal/infrastructure/agents/copilot_provider.go`: Map `dangerously_skip_permissions` option to `--allow-all` flag for cross-provider compatibility - `internal/infrastructure/agents/copilot_provider_unit_test.go`: Add tests for alias behavior, precedence when both options set, and false value omits flag
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dangerously_skip_permissionsas a cross-provider alias forallow_allin the Copilot provider, mapping it to the--allow-allCLI flagdangerously_skip_permissionsoption work without modification when targeting Copilot, improving provider portabilityallow_allanddangerously_skip_permissionsare set,allow_alltakes precedence and--allow-allappears exactly once in the CLI argsChanges
Infrastructure
internal/infrastructure/agents/copilot_provider.go: Addelse ifbranch inappendCopilotOptionsto handledangerously_skip_permissionsas an alias for--allow-allTests
internal/infrastructure/agents/copilot_provider_unit_test.go: Add table-driven test case fordangerously_skip_permissionsalias, plus two dedicated tests — one verifyingallow_alltakes precedence (deduplication), one verifyingfalsevalue omits the flagTest plan
make test-unitpasses with no failuresdangerously_skip_permissions: trueand confirm--allow-allis passed to the CLIallow_all: trueanddangerously_skip_permissions: trueand confirm--allow-allappears exactly oncedangerously_skip_permissions: falseand confirm--allow-allis absent from CLI argsGenerated with awf commit workflow