Skip to content

Conversation

@robd
Copy link
Contributor

@robd robd commented Jan 31, 2021

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sanjP10
Copy link

sanjP10 commented Feb 13, 2021

Hi,

Could you also remove ${{ github.workspace }} in this line

It seems to be causing issues with github action workflows when pulling master

Download action repository 'actions/checkout@v2'
Download action repository 'aws-actions/configure-aws-credentials@v1'
Download action repository 'aws-actions/aws-cloudformation-github-deploy@master'
Error: aws-actions/aws-cloudformation-github-deploy/master/action.yml (Line: 18, Col: 18):
Error: aws-actions/aws-cloudformation-github-deploy/master/action.yml (Line: 18, Col: 18): Unrecognized named-value: 'github'. Located at position 1 within expression: github.workspace
Error: Fail to load aws-actions/aws-cloudformation-github-deploy/master/action.yml

@robd
Copy link
Contributor Author

robd commented Feb 14, 2021

Hi @sanjP10

Thanks for your message. I wasn't able to see the build which failed - could you point me at this and I will take a look? Just to confirm - the error you're seeing is in the current master build, not related to this PR?

I'm keen to keep the documentation in there about how to use a local file for parameter-overrides if possible since this was very helpful when setting this up.

newrelic/deployment-marker-action#7 fixed this sort of docs issue for the deployment-marker-action project, so perhaps we could do something like this if I can reproduce the problem?

@sanjP10
Copy link

sanjP10 commented Feb 14, 2021

Hi @sanjP10

Thanks for your message. I wasn't able to see the build which failed - could you point me at this and I will take a look? Just to confirm - the error you're seeing is in the current master build, not related to this PR?

I'm keen to keep the documentation in there about how to use a local file for parameter-overrides if possible since this was very helpful when setting this up.

newrelic/deployment-marker-action#7 fixed this sort of docs issue for the deployment-marker-action project, so perhaps we could do something like this if I can reproduce the problem?

Hi,

Yes this is in relation to master, Screenshot 2021-02-14 at 21 11 09
Looking at it it seems something like you saw in newrelic/deployment-marker-action#7, so this can be done later.

      - name: Deploy VPC
        uses: aws-actions/aws-cloudformation-github-deploy@master
        with:
          name: <name>
          template: <yaml file>
          no-fail-on-empty-changeset: 1

If I use @v1 its fine

@ryanbtraveltek
Copy link

I'm also having the same issue as @sanjP10
Seems to be directly related to the ${{ github.workspace }} Once thats removed it works fine, switching to v1 rather than master also works.

@kddejong kddejong merged commit 7ad5b6a into aws-actions:master Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants