Skip to content

Conversation

@ameter
Copy link
Contributor

@ameter ameter commented May 3, 2022

Description of changes:
Add cocoapods caching to integration tests. This will speed up tests and eliminate 429 throttling errors from repeatedly cloning pods repos.

Check points: (check or cross out if not relevant)

  • [ ] Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • [ ] All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • [ ] Documentation update for the change if required
  • PR title conforms to conventional commit style
  • [ ] If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ameter ameter requested a review from a team May 3, 2022 01:31
@codecov-commenter
Copy link

codecov-commenter commented May 3, 2022

Codecov Report

Merging #1772 (e7e8ae6) into main (8f635d0) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1772   +/-   ##
=======================================
  Coverage   59.23%   59.23%           
=======================================
  Files         716      716           
  Lines       21916    21916           
=======================================
+ Hits        12982    12983    +1     
+ Misses       8934     8933    -1     
Flag Coverage Δ
API_plugin_unit_test 62.51% <ø> (ø)
AWSPluginsCore 71.37% <ø> (+0.07%) ⬆️
Amplify 46.83% <ø> (+0.01%) ⬆️
Analytics_plugin_unit_test 71.09% <ø> (ø)
Auth_plugin_unit_test 78.74% <ø> (ø)
DataStore_plugin_unit_test 76.09% <ø> (-0.02%) ⬇️
Geo_plugin_unit_test 52.12% <ø> (ø)
Predictions_plugin_unit_test 26.81% <ø> (ø)
Storage_plugin_unit_test 58.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...oreCategoryPlugin/Sync/Support/Model+Compare.swift 69.79% <0.00%> (-2.09%) ⬇️
...gin/Sync/InitialSync/ModelSyncedEventEmitter.swift 89.58% <0.00%> (-1.05%) ⬇️
...gin/Subscribe/DataStoreObserveQueryOperation.swift 75.58% <0.00%> (+0.93%) ⬆️
.../DataStore/Model/Internal/Schema/ModelSchema.swift 66.00% <0.00%> (+2.00%) ⬆️
...e/AWSPluginsCore/Auth/AWSAuthServiceBehavior.swift 87.50% <0.00%> (+12.50%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Contributor

@atierian atierian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Is it possible to manually run this action to confirm it works as expected?

@ameter
Copy link
Contributor Author

ameter commented May 3, 2022

Is it possible to manually run this action to confirm it works as expected?

Yes, I enabled this on a test branch to confirm.

@ameter ameter merged commit caf7410 into main May 3, 2022
@ameter ameter deleted the chore/cocoapods-caching branch May 3, 2022 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants