Skip to content

Conversation

@palpatim
Copy link
Member

Prevents errors for customers compiling with Swift toolchains < 5.2

refs:

Description of changes:

This fixes compilation errors on my local installation of Xcode 11.3.1.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Prevents errors for customers compiling with Swift toolchains < 5.2

refs:
- #717
- #740
- #744
@palpatim palpatim self-assigned this Sep 21, 2020
@palpatim palpatim added bug Something isn't working build Issues related to build and CI/CD core Amplify Core components labels Sep 21, 2020
@palpatim palpatim requested a review from drochetti September 21, 2020 21:27
Copy link
Contributor

@drochetti drochetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome! 🚀

@palpatim palpatim merged commit 3637f31 into main Sep 22, 2020
@palpatim palpatim deleted the palpatim/swift-52-version-check branch September 22, 2020 14:49
AlexTyurinV added a commit to AlexTyurinV/amplify-ios that referenced this pull request Sep 24, 2020
fix: Add #if swift check for Combine publishers (aws-amplify#775)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working build Issues related to build and CI/CD core Amplify Core components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants