Skip to content

Conversation

@palpatim
Copy link
Member

@palpatim palpatim commented Nov 5, 2020

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@palpatim palpatim requested a review from lawmicha November 5, 2020 19:33
@codecov
Copy link

codecov bot commented Nov 5, 2020

Codecov Report

Merging #875 into main will increase coverage by 0.58%.
The diff coverage is 77.96%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #875      +/-   ##
==========================================
+ Coverage   64.06%   64.65%   +0.58%     
==========================================
  Files         852      860       +8     
  Lines       33029    33880     +851     
==========================================
+ Hits        21160    21904     +744     
- Misses      11869    11976     +107     
Flag Coverage Δ
API_plugin_unit_test 62.49% <ø> (ø)
Analytics_plugin_unit_test 72.38% <ø> (ø)
Auth_plugin_unit_test 15.79% <ø> (ø)
DataStore_plugin_unit_test 82.93% <84.06%> (-0.13%) ⬇️
Predictions_plugin_unit_test 42.11% <ø> (ø)
Storage_plugin_unit_test 74.74% <ø> (ø)
build_test_amplify 63.94% <53.79%> (+0.94%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...aStore/Model/Internal/ModelRegistry+Syncable.swift 0.00% <0.00%> (ø)
...Model/Internal/Schema/ModelField+Association.swift 3.07% <0.00%> (+3.07%) ⬆️
...Categories/DataStore/Subscribe/MutationEvent.swift 0.00% <0.00%> (ø)
...reCategoryPlugin/Storage/SQLite/SQLStatement.swift 0.00% <0.00%> (ø)
...eCategoryPlugin/Storage/StorageEngineAdapter.swift 0.00% <0.00%> (ø)
...ests/Sync/InitialSync/ReadyEventEmitterTests.swift 100.00% <ø> (ø)
...fyTestCommon/Models/NonModel/DynamicEmbedded.swift 0.00% <0.00%> (ø)
...plifyTestCommon/Models/NonModel/DynamicModel.swift 0.00% <0.00%> (ø)
...age/SQLite/StorageEngineAdapter+UntypedModel.swift 22.58% <8.33%> (-5.42%) ⬇️
...nSync/Support/MockSQLiteStorageEngineAdapter.swift 52.88% <10.52%> (-8.92%) ⬇️
... and 85 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b40720a...0692fc2. Read the comment docs.

@palpatim palpatim merged commit 42c0c36 into main Nov 5, 2020
@palpatim palpatim deleted the palpatim/prep-release-1.4.1 branch November 5, 2020 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants