fix(DataStore): Nested query predicates are not stored properly #905
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #905 +/- ##
==========================================
- Coverage 64.89% 64.89% -0.01%
==========================================
Files 862 862
Lines 34182 34178 -4
==========================================
- Hits 22182 22179 -3
+ Misses 12000 11999 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
drochetti
approved these changes
Nov 21, 2020
Contributor
drochetti
left a comment
drochetti
left a comment
There was a problem hiding this comment.
makes more sense now! thanks for catching that
Contributor
Author
Shout out to @richardmcclellan for helping me debug this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Reference, android code:
https://github.com/aws-amplify/amplify-android/blame/12ec8e9819228f63bd677a0431a5ab191f79d9e1/core/src/main/java/com/amplifyframework/core/model/query/predicate/QueryPredicateGroup.java#L77
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.