-
Notifications
You must be signed in to change notification settings - Fork 227
feat(DataStore): Start/Stop implementation, 2nd approach #919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #919 +/- ##
==========================================
+ Coverage 67.27% 67.52% +0.25%
==========================================
Files 895 896 +1
Lines 35372 35638 +266
==========================================
+ Hits 23796 24066 +270
+ Misses 11576 11572 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
palpatim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed offline
palpatim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved w/ minor changes
...yPlugins/DataStore/AWSDataStoreCategoryPlugin/AWSDataStorePlugin+DataStoreBaseBehavior.swift
Show resolved
Hide resolved
Co-authored-by: Tim Schmelter <schmelte@amazon.com>
Co-authored-by: Tim Schmelter <schmelte@amazon.com>
…rePlugin+DataStoreBaseBehavior.swift Co-authored-by: Tim Schmelter <schmelte@amazon.com>
First approach was here:
#917
I realized late that we have effectively coupled the instantiation of the storageEngine with starting the syncEngine. The approach in this PR maintains this behavior in order to skirt around having to save state of whether or not the sync engine has been started in conjunction with the storage engine being instantiated. I believe that by preserving this coupling, makes for a significantly more elegant approach than the design/implementation in PR 917.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.