Skip to content

Conversation

@royjit
Copy link
Contributor

@royjit royjit commented Dec 21, 2020

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Dec 21, 2020

Codecov Report

Merging #989 (811b368) into main (7194840) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #989      +/-   ##
==========================================
+ Coverage   54.92%   54.94%   +0.02%     
==========================================
  Files         634      634              
  Lines       18372    18372              
==========================================
+ Hits        10090    10094       +4     
+ Misses       8282     8278       -4     
Flag Coverage Δ
API_plugin_unit_test 48.09% <ø> (+0.12%) ⬆️
AWSPluginsCore 72.41% <ø> (ø)
Amplify 45.81% <ø> (+0.04%) ⬆️
Analytics_plugin_unit_test 73.23% <ø> (ø)
Auth_plugin_unit_test 68.48% <ø> (ø)
DataStore_plugin_unit_test 71.02% <ø> (ø)
Predictions_plugin_unit_test 33.48% <ø> (ø)
Storage_plugin_unit_test 57.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...Categories/DataStore/Model/Internal/Embedded.swift 0.00% <ø> (ø)
...egories/DataStore/Model/Internal/Model+Array.swift 0.00% <ø> (ø)
...ories/DataStore/Model/Internal/Model+Codable.swift 51.72% <ø> (ø)
...ataStore/Model/Internal/Model+DateFormatting.swift 70.00% <ø> (ø)
...ies/DataStore/Model/Internal/Model+Subscript.swift 73.33% <ø> (ø)
...aStore/Model/Internal/ModelRegistry+Syncable.swift 0.00% <ø> (ø)
...egories/DataStore/Model/Internal/Persistable.swift 0.00% <ø> (ø)
...DataStore/Model/Internal/Schema/Model+Schema.swift 27.77% <ø> (ø)
...Model/Internal/Schema/ModelField+Association.swift 41.30% <ø> (ø)
...re/Model/Internal/Schema/ModelValueConverter.swift 0.00% <ø> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7194840...811b368. Read the comment docs.

@royjit royjit merged commit ee4a88f into main Dec 21, 2020
@royjit royjit deleted the royjit/UpdateComment branch December 21, 2020 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants