Skip to content

Conversation

@jacoblogan
Copy link
Contributor

Description of changes

Add design tokens and theme section to text area field primitive

Screen Shot 2022-06-13 at 4 25 07 AM

Description of how you validated changes

validated on docs site

Checklist

  • PR description included
  • yarn test passes
  • Tests are updated
  • No side effects or sideEffects field updated
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@changeset-bot
Copy link

changeset-bot bot commented Jun 13, 2022

🦋 Changeset detected

Latest commit: 62423cb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@aws-amplify/ui Minor
@aws-amplify/ui-react Patch
@aws-amplify/ui-vue Patch
@aws-amplify/ui-angular Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jacoblogan jacoblogan temporarily deployed to ci June 13, 2022 11:44 Inactive
@jacoblogan jacoblogan temporarily deployed to ci June 13, 2022 11:44 Inactive
@jacoblogan jacoblogan temporarily deployed to ci June 13, 2022 11:44 Inactive
@jacoblogan jacoblogan temporarily deployed to ci June 13, 2022 11:44 Inactive
Copy link
Contributor

@joebuono joebuono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add minor version bump

@jacoblogan jacoblogan temporarily deployed to ci June 13, 2022 18:41 Inactive
@jacoblogan jacoblogan temporarily deployed to ci June 13, 2022 18:41 Inactive
@jacoblogan jacoblogan temporarily deployed to ci June 13, 2022 18:41 Inactive
@jacoblogan jacoblogan temporarily deployed to ci June 13, 2022 18:41 Inactive
Copy link
Contributor

@zchenwei zchenwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jacoblogan jacoblogan temporarily deployed to ci June 14, 2022 18:16 Inactive
@jacoblogan jacoblogan temporarily deployed to ci June 14, 2022 18:16 Inactive
@jacoblogan jacoblogan temporarily deployed to ci June 14, 2022 18:16 Inactive
@jacoblogan jacoblogan temporarily deployed to ci June 14, 2022 18:16 Inactive
Copy link
Contributor

@reesscot reesscot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please answer one question below before merging.

</FieldGroupIconButton>
);
};
const SearchFieldButtonPrimitive: Primitive<SearchFieldButtonProps, 'button'> =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did anything change here, or is this just prettier being annoying?

@jacoblogan jacoblogan merged commit e37b666 into main Jun 14, 2022
@jacoblogan jacoblogan deleted the textarea-tokens branch June 14, 2022 18:52
@github-actions github-actions bot mentioned this pull request Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants