fix: provide prop-type on select-mfa-type #2706
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ui-component-props` handles `prop-type` as `attr` with no value only for the initial load. Passing a correct `prop-type` fixes an issue that showing `undefined` when user comes from different page. Fixes: aws-amplify#2705
renebrandel
requested review from
a team and
sammartinez
and removed request for
a team
Contributor
Author
|
@sammartinez This is just a friendly reminder that we are waiting for your review. Hope we can fix the issue together :) |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Contributor
Author
|
Ping to keep opening |
Contributor
Author
|
@sammartinez Kindly asking for your review to ship this as the issue is still happening. |
|
Circulated to @aws-amplify/amplify-js internally for review. Apologies for the delay, here. |
medelman17
approved these changes
Jun 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ui-component-propshandlesprop-typeasattrwith no value only for the initial load. Passing a correctprop-typefixes an issue that showingundefinedwhen user comes from different page which is how the other page manages prop-type.Fixes: #2705