Added writeOnlyProperties redaction to testEntrypoint #296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix allows the contract tests to correctly assert on writeOnlyProperties being removed from the model.
ammokhov
approved these changes
Aug 4, 2020
johnttompkins
approved these changes
Aug 4, 2020
Contributor
johnttompkins
left a comment
johnttompkins
left a comment
There was a problem hiding this comment.
This all looks to be good, but I think we should look into just removing the test entrypoint altogether since we have a synchronous response protocol now with the v2 protocol version. Would ease the pain of maintaining these two entrypoints.
Contributor
Author
Yeah that makes sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix allows the contract tests to correctly assert on writeOnlyProperties being removed from the model.
Issue #, if available: N/A
Description of changes: Contract tests were reporting false negatives for the redaction of
writeOnlyProperties. Minor refactoring so that thetestEntrypointalso sanitizes the model by default.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.