Skip to content

Conversation

@eduardomourar
Copy link
Contributor

Issue #, if available: #9

Description of changes:
This improves the deserialization of the raw model into the proper classes.

  • ser/de can now handle complex schemas containing arrays and objects (related to Data class with model validation #1)
  • CloudFormation service is casting all primitive types (integer, number, boolean) into strings. This provides a hacky, but easy-to-remove-once-fixed-upstream, convertor that re-casts them back to their intended types.

@codecov
Copy link

codecov bot commented Aug 5, 2020

Codecov Report

Merging #18 into master will increase coverage by 3.01%.
The diff coverage is 99.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #18      +/-   ##
==========================================
+ Coverage   94.45%   97.47%   +3.01%     
==========================================
  Files          11       13       +2     
  Lines         793      870      +77     
  Branches      118      148      +30     
==========================================
+ Hits          749      848      +99     
+ Misses         44       22      -22     
Flag Coverage Δ
#unittests 97.47% <99.55%> (+3.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/rpdk/typescript/utils.py 100.00% <ø> (ø)
src/utils.ts 100.00% <ø> (+16.94%) ⬆️
src/proxy.ts 96.49% <97.14%> (+16.13%) ⬆️
python/rpdk/typescript/codegen.py 100.00% <100.00%> (ø)
python/rpdk/typescript/resolver.py 100.00% <100.00%> (ø)
src/index.ts 100.00% <100.00%> (ø)
src/interface.ts 100.00% <100.00%> (+3.77%) ⬆️
src/log-delivery.ts 93.25% <100.00%> (ø)
src/metrics.ts 100.00% <100.00%> (ø)
src/recast.ts 100.00% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d14c9f...6e2a80c. Read the comment docs.

@eduardomourar eduardomourar marked this pull request as ready for review August 9, 2020 12:46
@eduardomourar eduardomourar changed the title improve model deserialization Improve model deserialization Aug 9, 2020
@eduardomourar eduardomourar merged commit 81d357a into master Aug 9, 2020
@eduardomourar eduardomourar deleted the feature/recast-primitives branch August 9, 2020 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant