Skip to content

Conversation

@PatMyron
Copy link
Contributor

@PatMyron PatMyron commented Apr 13, 2021

introduced in #43, but docker is already an indirect dependency from cloudformation-cli, so this was just pinning docker version stricter than cloudformation-cli, which causes issues
aws-cloudformation/cloudformation-cli#706
aws-cloudformation/cloudformation-cli#727
aws-cloudformation/cloudformation-cli#759
aws-cloudformation/cloudformation-cli-python-plugin#147

@codecov
Copy link

codecov bot commented Apr 13, 2021

Codecov Report

Merging #50 (1446dad) into master (4bcde0a) will not change coverage.
The diff coverage is n/a.

❗ Current head 1446dad differs from pull request most recent head 3b8ea1b. Consider uploading reports for the commit 3b8ea1b to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master      #50   +/-   ##
=======================================
  Coverage   98.93%   98.93%           
=======================================
  Files          13       13           
  Lines        1215     1215           
  Branches      212      212           
=======================================
  Hits         1202     1202           
  Misses         13       13           
Flag Coverage Δ
unittests 98.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bcde0a...3b8ea1b. Read the comment docs.

@ammokhov ammokhov merged commit 32b9df8 into master Apr 13, 2021
@PatMyron PatMyron deleted the docker branch April 13, 2021 17:12
@PatMyron PatMyron added the dependencies Pull requests that update a dependency file label Apr 13, 2021
@shadow-light
Copy link

Any reason why this hasn't been released yet? Noticed it was committed 5 months ago and just ran into the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants