Skip to content

Conversation

@ammokhov
Copy link
Contributor

@ammokhov ammokhov commented Apr 8, 2021

Issue #, if available:

TypeScript Lib:

  1. Changed node.js library name cfn-rpdk -> cloudformation-cli-typescript-lib
  2. Bumped the release lib version 0.5.0 -> 1.0.0
  3. Changed authors/url/license

Python Tool:

1. Bumped the release plugin version 0.5.0 -> 1.0.0
2. Changed authors/url/license
3. Added docker dependency as in codegen docker is set to True
4. Changed lib name in codegen cfn-rpdk -> cloudformation-cli-typescript-lib
5. Removed lib url from the codegen as it will pick up package from NPM

Description of changes:

@ammokhov ammokhov self-assigned this Apr 8, 2021
@ammokhov ammokhov requested review from omkhegde and wbingli April 8, 2021 19:07
@ammokhov
Copy link
Contributor Author

ammokhov commented Apr 8, 2021

@eduardomourar could you help review the changes?

@ammokhov ammokhov requested a review from PatMyron April 8, 2021 19:08
@ammokhov ammokhov force-pushed the release-version-v1 branch from 365d78c to 1175bbf Compare April 8, 2021 20:38
@codecov
Copy link

codecov bot commented Apr 8, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@a70b01b). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head c4a680a differs from pull request most recent head 1175bbf. Consider uploading reports for the commit 1175bbf to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##             master      #43   +/-   ##
=========================================
  Coverage          ?   98.93%           
=========================================
  Files             ?       13           
  Lines             ?     1218           
  Branches          ?      212           
=========================================
  Hits              ?     1205           
  Misses            ?       13           
  Partials          ?        0           
Flag Coverage Δ
unittests 98.93% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a70b01b...1175bbf. Read the comment docs.

@ammokhov ammokhov changed the title Changed Lib name and some settings. Prepare for release Changed Lib name and some settings. Prepare for library release Apr 8, 2021
@ammokhov ammokhov merged commit eb7ec32 into aws-cloudformation:master Apr 8, 2021
@ammokhov ammokhov deleted the release-version-v1 branch April 8, 2021 21:20
@eduardomourar
Copy link
Contributor

@eduardomourar could you help review the changes?

LGTM

install_requires=["cloudformation-cli>=0.1.14", "zipfile38>=0.0.3,<0.2"],
install_requires=[
"cloudformation-cli>=0.1.14",
"docker>=3.7,<5",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason for pinning docker versions? (since docker is already an indirect dependency through cloudformation-cli)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legacy code. It was added when cfn-CLI didn't have docker. And because we have a implicit dependency on SAM CLI which does require docker: https://github.com/aws-cloudformation/cloudformation-cli-typescript-plugin/blob/master/python/rpdk/typescript/codegen.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants