-
Notifications
You must be signed in to change notification settings - Fork 16
Changed Lib name and some settings. Prepare for library release #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed Lib name and some settings. Prepare for library release #43
Conversation
|
@eduardomourar could you help review the changes? |
365d78c to
1175bbf
Compare
Codecov Report
@@ Coverage Diff @@
## master #43 +/- ##
=========================================
Coverage ? 98.93%
=========================================
Files ? 13
Lines ? 1218
Branches ? 212
=========================================
Hits ? 1205
Misses ? 13
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
LGTM |
| install_requires=["cloudformation-cli>=0.1.14", "zipfile38>=0.0.3,<0.2"], | ||
| install_requires=[ | ||
| "cloudformation-cli>=0.1.14", | ||
| "docker>=3.7,<5", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the reason for pinning docker versions? (since docker is already an indirect dependency through cloudformation-cli)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Legacy code. It was added when cfn-CLI didn't have docker. And because we have a implicit dependency on SAM CLI which does require docker: https://github.com/aws-cloudformation/cloudformation-cli-typescript-plugin/blob/master/python/rpdk/typescript/codegen.py
Issue #, if available:
TypeScript Lib:
cfn-rpdk->cloudformation-cli-typescript-lib0.5.0->1.0.0Python Tool:
1. Bumped the release plugin version0.5.0->1.0.02. Changed authors/url/license3. Added docker dependency as in codegen docker is set to True4. Changed lib name in codegencfn-rpdk->cloudformation-cli-typescript-lib5. Removed lib url from the codegen as it will pick up package from NPMDescription of changes: