-
Notifications
You must be signed in to change notification settings - Fork 172
Add additional checks on structured properties to not leak the additional properties to handlers during validation #642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional checks on structured properties to not leak the additional properties to handlers during validation #642
Conversation
…onal properties to handlers during validation
|
Do we need to define what a structured property is? Also "additionalProperties" are a property of object schemas and are required only there. |
ammokhov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
…onal properties to handlers during validation (aws-cloudformation#642)
…onal properties to handlers during validation (aws-cloudformation#642)
|
seems explicitly documented that "use of Should try to check why that was documented and update that documentation if that's no longer the case |
|
Use of |
|
@srujithpoondla03 got it, maybe just re-worded to clarify then? |
…onal properties to handlers during validation (aws-cloudformation#642)
…onal properties to handlers during validation (aws-cloudformation#642)
Description of changes:
Currently, in the provider definition schema we do not restrict the structured property to specify the additionalProperties as false. Structured properties should define the additionalProperties as false otherwise properties with different case or pattern could not be caught during validation.
Tested by running the
cfn validateBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.