Conversation
d10f0ab to
29d1d86
Compare
satyakigh
reviewed
Oct 23, 2025
satyakigh
reviewed
Oct 23, 2025
39c48de to
674eda8
Compare
satyakigh
approved these changes
Oct 23, 2025
674eda8 to
bb12c37
Compare
chrisqm-dev
approved these changes
Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Server-Side Pagination for CloudFormation LSP
Summary
Implements server-side pagination for stacks and resources, improving performance when working with large AWS accounts.
Key Changes
New: StackManager
Map<stackId, StackSummary>nextToken; client sendsloadMorebooleanEnhanced: ResourceStateManager
searchResourceByIdentifier()method for finding specific resources and adding to cacheRefactored: CfnService
Protocol Updates
ListStacksParams: UsesloadMoreboolean instead ofnextTokenSearchResourceRequest: New protocol for resource searchFiles Changed
New:
StackManager.ts,StackManager.test.tsModified:
CfnService.ts,ResourceStateManager.ts,ResourceStateTypes.ts,StackHandler.ts,ResourceHandler.ts,CfnLspProviders.ts,CfnServer.ts,DeploymentWorkflow.tsNotes
MaxResultsis non-functional (marked "Reserved")ListStackshas no default page sizeBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.