Skip to content

change resource state import from CodeAction to CompletionItem with t…#142

Merged
satyakigh merged 1 commit intomainfrom
resource-state-as-completion
Nov 4, 2025
Merged

change resource state import from CodeAction to CompletionItem with t…#142
satyakigh merged 1 commit intomainfrom
resource-state-as-completion

Conversation

@Zee2413
Copy link
Contributor

@Zee2413 Zee2413 commented Oct 28, 2025

…abstop placeholders

Description of changes:

  • change the resource state insertion from CodeAction to CompletionItem
  • values required user input have tab stops with placeholder text such as:
    • write only required property for LambdaFunction1
  • primary identifiers no longer require user input
    • i.e., no placeholder for BucketName when cloning AWS::S3::Bucket
  • using EditorSettings for indentation instead of previously hardcoded indentation of '2'
  • insertion of text on client side is changing from workspace.applyEdit() to SnippetString which applies auto indentation and supports tabstops
    • this necessitated many formatting changes in server side

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Zee2413 Zee2413 requested a review from a team as a code owner October 28, 2025 14:01
@Zee2413 Zee2413 force-pushed the resource-state-as-completion branch from 969071c to c174ae6 Compare October 28, 2025 14:12
@Zee2413 Zee2413 marked this pull request as draft October 28, 2025 18:22
@Zee2413 Zee2413 force-pushed the resource-state-as-completion branch from c174ae6 to 19812d2 Compare November 3, 2025 21:38
@Zee2413 Zee2413 force-pushed the resource-state-as-completion branch from 19812d2 to c7ded4d Compare November 3, 2025 21:45
@Zee2413 Zee2413 marked this pull request as ready for review November 3, 2025 21:46
@Zee2413 Zee2413 force-pushed the resource-state-as-completion branch 2 times, most recently from 73fac51 to c1d6280 Compare November 4, 2025 17:07
satyakigh
satyakigh previously approved these changes Nov 4, 2025
@Zee2413 Zee2413 force-pushed the resource-state-as-completion branch from c1d6280 to 1827886 Compare November 4, 2025 17:43
@Zee2413 Zee2413 force-pushed the resource-state-as-completion branch from 1827886 to b6b578b Compare November 4, 2025 19:24
@Zee2413 Zee2413 force-pushed the resource-state-as-completion branch from b6b578b to a430601 Compare November 4, 2025 20:13
@satyakigh satyakigh merged commit 689fc1b into main Nov 4, 2025
10 checks passed
@satyakigh satyakigh deleted the resource-state-as-completion branch November 4, 2025 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants