Add e2e and int tests for guard diagnostics#360
Merged
Conversation
9a0e051 to
3b9a3c5
Compare
satyakigh
reviewed
Dec 12, 2025
682e6d4 to
4c30933
Compare
atennak1
previously approved these changes
Mar 2, 2026
gemammercado
previously approved these changes
Mar 3, 2026
e917dbb to
8a07ce1
Compare
8a07ce1 to
ca8a16a
Compare
satyakigh
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Add e2e and integration tests for Guard diagnostics, covering the full diagnostic lifecycle through the LSP protocol.
E2E tests (
tst/e2e/Diagnostics.test.ts) — real LSP client/server over JSON-RPC:Integration tests (
tst/integration/diagnostics/Guard.test.ts) — TemplateBuilder with real GuardService:Test utilities:
DiagnosticExpectationBuilderfor declarative diagnostic assertions (source, message pattern, severity, count)TestExtensiongainsreceivedDiagnosticstracking andmockWorkspaceConfigfor settingstest-guard-rules.guard) for deterministic e2e testingBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.