-
Notifications
You must be signed in to change notification settings - Fork 20
Update to ACK runtime v0.56.0, code-generator v0.56.0
#155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
||
| jobs: | ||
| call-hydrate-go-proxy: | ||
| uses: aws-controllers-k8s/.github/.github/workflows/reusable-postsubmit.yaml@main |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 13 days ago
To fix the issue, you must add an explicit permissions block to the workflow, either at the top level (root of the YAML) to apply to all jobs, or within the specific job definition to restrict that job's permissions. In this case, there is only a single job, so adding the permissions block at the root is preferrable for clarity, but placing it inside the job would also suffice. The minimal required permissions need to be chosen; if the workflow only needs the ability to read repository contents, contents: read is considered lowest privilege. If additional privileges are required by the called (reusable) workflow, you'd mirror those, but starting with contents: read is the secure default. Edit .github/workflows/postsubmit.yaml to include:
- Insert a
permissions:block after thename:line, beforeon:(recommended location for root-level). - The block should minimally be:
This adheres to the principle of least privilege and satisfies CodeQL's requirements.permissions: contents: read
No imports, definitions, or extra methods are needed; YAML structure only.
-
Copy modified lines R2-R3
| @@ -1,4 +1,6 @@ | ||
| name: Hydrate Go Proxy | ||
| permissions: | ||
| contents: read | ||
|
|
||
| on: | ||
| push: |
|
@ack-bot: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, ack-bot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Update to ACK runtime
v0.56.0, code-generatorv0.56.0v0.56.0release notesv0.56.0release notesNOTE:
This PR increments the release version of service controller from
v1.1.2tov1.2.0Once this PR is merged, release
v1.2.0will be automatically created forapplicationautoscaling-controllerPlease close this PR, if you do not want the new patch release for
applicationautoscaling-controllerstdout for
make build-controller:By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.