Skip to content

Conversation

@RedbackThomson
Copy link
Contributor

Description of changes:

  • Helm chart had an additional, faulty, service definition
  • Upgrade acktest to support the LOAD_IN_CLUSTER_KUBECONFIG (for soak tests)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mbaijal
Copy link
Contributor

mbaijal commented Sep 14, 2021

/lgtm

@ack-bot ack-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 14, 2021
@ack-bot
Copy link
Collaborator

ack-bot commented Sep 14, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mbaijal, RedbackThomson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [RedbackThomson,mbaijal]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-bot ack-bot merged commit 83d9f84 into aws-controllers-k8s:main Sep 14, 2021
ack-bot pushed a commit that referenced this pull request Sep 16, 2021
Issue #, if available:
release artifacts for release v0.1.0

Release Notes draft:
This release includes the following resources and updates:
 - Enables the AdoptedResource Feature for both `ScalableTarget` and `ScalingPolicy` ( #47 ).
 - Uses the server side `CreationTime` to set the `LastModifiedTime` the very first time ( #49 ).
 - Some release and helm test related changes ( #48 and #50).


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants