Skip to content

Conversation

@ryansteakley
Copy link
Member

Release Notes Draft:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ryansteakley
Copy link
Member Author

/retest

@ryansteakley
Copy link
Member Author

/test applicationautoscaling-kind-e2e

1 similar comment
@mbaijal
Copy link
Contributor

mbaijal commented Sep 23, 2021

/test applicationautoscaling-kind-e2e

@vijtrip2
Copy link
Contributor

vijtrip2 commented Sep 23, 2021

There's a new auto-generated PR out for ACK runtime v0.14.1
Why don't y'all merge that in, then add your changes on top of that and then release your latest artifacts?

@mbaijal
Copy link
Contributor

mbaijal commented Sep 23, 2021

/lgtm

@ack-bot
Copy link
Collaborator

ack-bot commented Sep 23, 2021

@mbaijal: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ryansteakley
Copy link
Member Author

There's a new auto-generated PR out for ACK runtime v0.14.1
Why don't y'all merge that in, then add your changes on top of that and then release your latest artifacts?

Hey Vijay, we plan to do another separate release for those changes. This was a miss in our previous release that we are fixing.

@mbaijal
Copy link
Contributor

mbaijal commented Sep 23, 2021

/lgtm

@ack-bot
Copy link
Collaborator

ack-bot commented Sep 23, 2021

@mbaijal: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mbaijal
Copy link
Contributor

mbaijal commented Sep 23, 2021

/LGTM

@ack-bot
Copy link
Collaborator

ack-bot commented Sep 23, 2021

@mbaijal: changing LGTM is restricted to collaborators

In response to this:

/LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mbaijal
Copy link
Contributor

mbaijal commented Sep 23, 2021

/lgtm

@ack-bot ack-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2021
@ack-bot
Copy link
Collaborator

ack-bot commented Sep 23, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mbaijal, ryansteakley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [mbaijal,ryansteakley]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-bot ack-bot merged commit 243d1d8 into aws-controllers-k8s:main Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants