-
Notifications
You must be signed in to change notification settings - Fork 6
Update to ACK runtime v0.56.0, code-generator v0.56.0
#41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@ack-bot: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
|
||
| jobs: | ||
| call-hydrate-go-proxy: | ||
| uses: aws-controllers-k8s/.github/.github/workflows/reusable-postsubmit.yaml@main |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 3 days ago
To fix this problem, we should add a permissions block to .github/workflows/postsubmit.yaml. The permissions block can be placed either at the root of the workflow or at the job level (call-hydrate-go-proxy). Since this workflow merely calls a reusable workflow and does not itself require any privileged actions (like writing contents or managing issues/pull requests), the minimal safe configuration is usually contents: read, unless we know specific additional permissions are required by the called reusable workflow.
In detail, add:
- At the root level, immediately below
name: Hydrate Go Proxy, add
This sets the minimal read-only permission for GITHUB_TOKEN for all jobs in this workflow unless overridden. If the called workflow needs more permissions, adjust accordingly.permissions: contents: read
No new methods or imports are needed. Only an edit to the YAML file is required.
-
Copy modified lines R2-R3
| @@ -1,4 +1,6 @@ | ||
| name: Hydrate Go Proxy | ||
| permissions: | ||
| contents: read | ||
|
|
||
| on: | ||
| push: |
|
/test all |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, ack-bot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Update to ACK runtime
v0.56.0, code-generatorv0.56.0v0.56.0release notesv0.56.0release notesNOTE:
This PR increments the release version of service controller from
v1.1.2tov1.2.0Once this PR is merged, release
v1.2.0will be automatically created forathena-controllerPlease close this PR, if you do not want the new patch release for
athena-controllerstdout for
make build-controller:By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.