Skip to content

Conversation

@michaelhtm
Copy link
Member

@michaelhtm michaelhtm commented Nov 13, 2025

stdout for make build-controller:

building ack-generate ... ok.
==== building bedrockagentcorecontrol-controller ====
Copying common custom resource definitions into bedrockagentcorecontrol
Building Kubernetes API objects for bedrockagentcorecontrol
Generating deepcopy code for bedrockagentcorecontrol
Generating custom resource definitions for bedrockagentcorecontrol
Building service controller for bedrockagentcorecontrol
Running GO mod tidy
Generating RBAC manifests for bedrockagentcorecontrol
Running gofmt against generated code for bedrockagentcorecontrol
Updating additional GitHub repository maintenance files
==== building bedrockagentcorecontrol-controller release artifacts ====
Building release artifacts for bedrockagentcorecontrol-v1.0.1
Generating common custom resource definitions
Generating custom resource definitions for bedrockagentcorecontrol
Generating RBAC manifests for bedrockagentcorecontrol  

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested review from a-hilaly and rushmash91 November 13, 2025 01:29
@ack-prow ack-prow bot added the approved label Nov 13, 2025
```
building ack-generate ... ok.
==== building bedrockagentcorecontrol-controller ====
Copying common custom resource definitions into bedrockagentcorecontrol
Building Kubernetes API objects for bedrockagentcorecontrol
Generating deepcopy code for bedrockagentcorecontrol
Generating custom resource definitions for bedrockagentcorecontrol
Building service controller for bedrockagentcorecontrol
Running GO mod tidy
Generating RBAC manifests for bedrockagentcorecontrol
Running gofmt against generated code for bedrockagentcorecontrol
Updating additional GitHub repository maintenance files
==== building bedrockagentcorecontrol-controller release artifacts ====
Building release artifacts for bedrockagentcorecontrol-v1.0.1
Generating common custom resource definitions
Generating custom resource definitions for bedrockagentcorecontrol
Generating RBAC manifests for bedrockagentcorecontrol
```
@michaelhtm michaelhtm force-pushed the rt-v0.53.1-codegen-v0.53.1 branch from f064491 to 0d73b8f Compare November 13, 2025 02:02
@ack-prow
Copy link

ack-prow bot commented Nov 13, 2025

@michaelhtm: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
bedrockagentcorecontrol-verify-attribution 0d73b8f link false /test bedrockagentcorecontrol-verify-attribution
bedrockagentcorecontrol-verify-code-gen 0d73b8f link false /test bedrockagentcorecontrol-verify-code-gen

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2025
@ack-prow
Copy link

ack-prow bot commented Nov 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, michaelhtm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [a-hilaly,michaelhtm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot merged commit 05e62ac into aws-controllers-k8s:main Nov 13, 2025
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants