Skip to content

Conversation

@ack-bot
Copy link
Collaborator

@ack-bot ack-bot commented Nov 29, 2025

Update to ACK runtime v0.56.0, code-generator v0.56.0



NOTE:
This PR increments the release version of service controller from v1.0.1 to v1.1.0

Once this PR is merged, release v1.1.0 will be automatically created for bedrockagentcorecontrol-controller

Please close this PR, if you do not want the new patch release for bedrockagentcorecontrol-controller


stdout for make build-controller:

building ack-generate ... ok.
==== building bedrockagentcorecontrol-controller ====
Copying common custom resource definitions into bedrockagentcorecontrol
Building Kubernetes API objects for bedrockagentcorecontrol
Generating deepcopy code for bedrockagentcorecontrol
Generating custom resource definitions for bedrockagentcorecontrol
Building service controller for bedrockagentcorecontrol
Running GO mod tidy
Generating RBAC manifests for bedrockagentcorecontrol
Running gofmt against generated code for bedrockagentcorecontrol
Updating additional GitHub repository maintenance files
==== building bedrockagentcorecontrol-controller release artifacts ====
Building release artifacts for bedrockagentcorecontrol-v1.1.0
Generating common custom resource definitions
Generating custom resource definitions for bedrockagentcorecontrol
Generating RBAC manifests for bedrockagentcorecontrol

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-bot ack-bot added the prow/auto-gen PRs related to prow auto generation automation label Nov 29, 2025
@ack-prow ack-prow bot requested review from a-hilaly and michaelhtm November 29, 2025 03:43

jobs:
call-hydrate-go-proxy:
uses: aws-controllers-k8s/.github/.github/workflows/reusable-postsubmit.yaml@main

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {}

Copilot Autofix

AI 6 days ago

To fix the problem, we should add an explicit permissions block to the job definition (or at the workflow root), specifying only the minimal permissions required. Because this workflow delegates work to a reusable workflow using uses:, the permissions in this file control what is granted to the called workflow unless it further restricts them. As a safe minimal default, set all permissions to read (or none if absolutely no access is needed), and grant more if the called workflow requires it. The best place to insert the permissions block for a single-job workflow is at the job level, just before (or after) the uses line in job definition. Since we don't know the specific needs of the called workflow, we should use the recommended least privilege starting point, such as:

permissions:
  contents: read

If you know more is needed, you could expand this. For now, insert this block under the job call-hydrate-go-proxy:.


Suggested changeset 1
.github/workflows/postsubmit.yaml

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/.github/workflows/postsubmit.yaml b/.github/workflows/postsubmit.yaml
--- a/.github/workflows/postsubmit.yaml
+++ b/.github/workflows/postsubmit.yaml
@@ -7,4 +7,6 @@
 
 jobs:
   call-hydrate-go-proxy:
+    permissions:
+      contents: read
     uses: aws-controllers-k8s/.github/.github/workflows/reusable-postsubmit.yaml@main
EOF
@@ -7,4 +7,6 @@

jobs:
call-hydrate-go-proxy:
permissions:
contents: read
uses: aws-controllers-k8s/.github/.github/workflows/reusable-postsubmit.yaml@main
Copilot is powered by AI and may make mistakes. Always verify output.
@ack-prow
Copy link

ack-prow bot commented Nov 29, 2025

@ack-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
bedrockagentcorecontrol-verify-code-gen 5983759 link false /test bedrockagentcorecontrol-verify-code-gen

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@a-hilaly
Copy link
Member

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 29, 2025
@ack-prow
Copy link

ack-prow bot commented Nov 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, ack-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot added the approved label Nov 29, 2025
@ack-prow ack-prow bot merged commit 59db2f7 into main Nov 29, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm Indicates that a PR is ready to be merged. prow/auto-gen PRs related to prow auto generation automation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants