Skip to content

Conversation

@michaelhtm
Copy link
Member

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested review from a-hilaly and knottnt November 29, 2025 00:50
@ack-prow ack-prow bot added the approved label Nov 29, 2025
@a-hilaly
Copy link
Member

/test ec2-controller-test

@a-hilaly a-hilaly added the version/minor Indicates downstream controller releases should bump the minor version. label Nov 29, 2025
@ack-prow
Copy link

ack-prow bot commented Nov 29, 2025

@michaelhtm: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
verify-attribution 6345183 link false /test verify-attribution
s3-olm-test 6345183 link false /test s3-olm-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@knottnt
Copy link
Contributor

knottnt commented Nov 29, 2025

/test ec2-controller-test

1 similar comment
@michaelhtm
Copy link
Member Author

/test ec2-controller-test

Copy link
Contributor

@knottnt knottnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 29, 2025
@ack-prow
Copy link

ack-prow bot commented Nov 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knottnt, michaelhtm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot merged commit 23c7074 into aws-controllers-k8s:main Nov 29, 2025
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm Indicates that a PR is ready to be merged. version/minor Indicates downstream controller releases should bump the minor version.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants