replace conditional synced condition with ready condition in printcolumn #646
Conversation
|
/test s3-controller-test |
| {{- if .CRD.PrintSyncedColumn }} | ||
| // +kubebuilder:printcolumn:name="Synced",type="string",priority=0,JSONPath=".status.conditions[?(@.type==\"ACK.ResourceSynced\")].status" | ||
| {{- end }} | ||
| // +kubebuilder:printcolumn:name="Ready",type="string",priority=0,JSONPath=".status.conditions[?(@.type==\"Ready\")].status" |
There was a problem hiding this comment.
Maybe we need to still wrap it with {{- if .CRD.PrintSyncedColumn }} ?
There was a problem hiding this comment.
Is there a reason why we had that?
I would think we want to print the Synced/Ready conditions all the time
There was a problem hiding this comment.
fair. let's remove PrintSyncedColumn ?
michaelhtm
force-pushed
the
addreadyconditionbydefault
branch
from
01755dc to
9bcb3db
Compare
|
@michaelhtm: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, michaelhtm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2 participants
Issue #2204
Description of changes:
This change adds removes the conditional check that adds the Synced condition,
and replaces it with a default Ready condition.
Ready condition represents that the resource is ready to be consumed by whatever it
depends on
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.