Skip to content

Update to ACK runtime v0.56.0, code-generator v0.56.0 #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 29, 2025
Merged

Update to ACK runtime v0.56.0, code-generator v0.56.0 #51

merged 1 commit into from
Nov 29, 2025

Conversation

@ack-bot
Copy link
Collaborator

@ack-bot ack-bot commented Nov 29, 2025

Update to ACK runtime v0.56.0, code-generator v0.56.0

NOTE:
This PR increments the release version of service controller from v1.1.2 to v1.2.0

Once this PR is merged, release v1.2.0 will be automatically created for documentdb-controller

Please close this PR, if you do not want the new patch release for documentdb-controller

stdout for make build-controller:

building ack-generate ... ok.
==== building documentdb-controller ====
Copying common custom resource definitions into documentdb
Building Kubernetes API objects for documentdb
Generating deepcopy code for documentdb
Generating custom resource definitions for documentdb
Building service controller for documentdb
Running GO mod tidy
Generating RBAC manifests for documentdb
Running gofmt against generated code for documentdb
Updating additional GitHub repository maintenance files
==== building documentdb-controller release artifacts ====
Building release artifacts for documentdb-v1.2.0
Generating common custom resource definitions
Generating custom resource definitions for documentdb
Generating RBAC manifests for documentdb

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-bot ack-bot added the prow/auto-gen PRs related to prow auto generation automation label Nov 29, 2025
@ack-prow ack-prow bot requested review from michaelhtm and rushmash91 November 29, 2025 03:22
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 29, 2025
View reviewed changes
.github/workflows/postsubmit.yaml

jobs:
call-hydrate-go-proxy:
uses: aws-controllers-k8s/.github/.github/workflows/reusable-postsubmit.yaml@main

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {}

Copilot Autofix

AI 5 days ago

To fix the issue, you should set an explicit permissions block at the workflow level or at the job level in .github/workflows/postsubmit.yaml. Since this workflow calls a reusable workflow and does not appear to require write access itself, a safe minimal starting point would be to add permissions: {} at the root of the workflow file to restrict all permissions unless specifically expanded in a job or the reusable workflow. This change should be added just after the workflow name (between lines 1 and 3) to apply to all jobs unless otherwise specified.

No new imports, functions, or more complex changes are required.

Suggested changeset 1
.github/workflows/postsubmit.yaml

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/.github/workflows/postsubmit.yaml b/.github/workflows/postsubmit.yaml
--- a/.github/workflows/postsubmit.yaml
+++ b/.github/workflows/postsubmit.yaml
@@ -1,4 +1,5 @@
 name: Hydrate Go Proxy
+permissions: {}
 
 on:
   push:
EOF
@@ -1,4 +1,5 @@
name: Hydrate Go Proxy
permissions: {}

on:
push:
Copilot is powered by AI and may make mistakes. Always verify output.
@ack-prow
Copy link

ack-prow bot commented Nov 29, 2025

@ack-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
documentdb-verify-code-gen da04617 link false /test documentdb-verify-code-gen

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@a-hilaly
Copy link
Member

a-hilaly commented Nov 29, 2025

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 29, 2025
@ack-prow
Copy link

ack-prow bot commented Nov 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, ack-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot added the approved label Nov 29, 2025
@ack-prow ack-prow bot merged commit 0fb08f4 into main Nov 29, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michaelhtm michaelhtm Awaiting requested review from michaelhtm

@rushmash91 rushmash91 Awaiting requested review from rushmash91

Assignees

@a-hilaly a-hilaly

Labels

approved lgtm Indicates that a PR is ready to be merged. prow/auto-gen PRs related to prow auto generation automation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ack-bot @a-hilaly