-
Notifications
You must be signed in to change notification settings - Fork 25
Update to ACK runtime v0.54.1, code-generator v0.54.0
#136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
||
| jobs: | ||
| call-hydrate-go-proxy: | ||
| uses: aws-controllers-k8s/.github/.github/workflows/reusable-postsubmit.yaml@main |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 12 days ago
The best way to fix this problem is to add a permissions block at the root of the workflow file (.github/workflows/postsubmit.yaml). This block ensures that all jobs (including those using uses: for reusable workflows) get the defined least-privilege permissions for GITHUB_TOKEN. As a starting point, set contents: read, which is typically sufficient for most postsubmit trigger jobs, unless more granular write permissions (such as issues: write or pull-requests: write) are specifically needed for the job or called workflows. Place the permissions block immediately below the workflow name and before the on: key, or just under the on: key (both positions are valid, but conventionally it's placed after the name). The code change consists of a single block insertion.
-
Copy modified lines R2-R3
| @@ -1,4 +1,6 @@ | ||
| name: Hydrate Go Proxy | ||
| permissions: | ||
| contents: read | ||
|
|
||
| on: | ||
| push: |
|
@ack-bot: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
a-hilaly
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, ack-bot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Update to ACK runtime
v0.54.1, code-generatorv0.54.0v0.54.0release notesv0.54.1release notesNOTE:
This PR increments the release version of service controller from
v1.3.2tov1.3.3Once this PR is merged, release
v1.3.3will be automatically created forecr-controllerPlease close this PR, if you do not want the new patch release for
ecr-controllerstdout for
make build-controller:By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.