Add support for Repository Policy
#49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: aws-controllers-k8s/community#582 Description of changes: - Added a new field named `Policy `to the `Repository` CRD (from the `SetRepositoryPolicy` API Call. - Add e2e tests for CRUD operations on `Policy` field - Refactor `setAddtionalFields` hook function - Fix some e2e rare error appearing when trying to patch a outdated CR
Contributor
|
/lgtm |
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: A-Hilaly, jaypipes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@jaypipes @a-hilaly there seem to be a bug or some kind of race condition with this feature - aws-controllers-k8s/community#1873 |
Member
Author
|
@jackivanov Fixed in v1.0.9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: aws-controllers-k8s/community#582
Description of changes:
Policyto theRepositoryCRD (from theSetRepositoryPolicyAPI Call.PolicyfieldsetAddtionalFieldshook functionBy submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license.