Skip to content

Conversation

@ack-bot
Copy link
Collaborator

@ack-bot ack-bot commented Aug 13, 2024

Update to ACK runtime v0.37.1, code-generator v0.37.0



NOTE:
This PR increments the release version of service controller from v1.4.4 to v1.4.5

Once this PR is merged, release v1.4.5 will be automatically created for eks-controller

Please close this PR, if you do not want the new patch release for eks-controller


stdout for make build-controller:

building ack-generate ... ok.
==== building eks-controller ====
Copying common custom resource definitions into eks
Building Kubernetes API objects for eks
Generating deepcopy code for eks
Generating custom resource definitions for eks
Building service controller for eks
Generating RBAC manifests for eks
Running gofmt against generated code for eks
Updating additional GitHub repository maintenance files
==== building eks-controller release artifacts ====
Building release artifacts for eks-v1.4.5
Generating common custom resource definitions
Generating custom resource definitions for eks
Generating RBAC manifests for eks

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-bot ack-bot added the prow/auto-gen PRs related to prow auto generation automation label Aug 13, 2024
@ack-prow ack-prow bot requested a review from a-hilaly August 13, 2024 17:57
@ack-prow
Copy link

ack-prow bot commented Aug 13, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ack-bot
Once this PR has been reviewed and has the lgtm label, please assign a-hilaly for approval by writing /assign @a-hilaly in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot requested a review from jlbutler August 13, 2024 17:57
@ack-prow
Copy link

ack-prow bot commented Aug 30, 2024

@ack-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
eks-verify-attribution 5cbb3bb link true /test eks-verify-attribution

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@a-hilaly a-hilaly closed this Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

prow/auto-gen PRs related to prow auto generation automation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants