Skip to content

Fix incorrect delta comparison for ConfigurationValues#215

Merged
ack-prow[bot] merged 1 commit into
aws-controllers-k8s:mainfrom
gustavodiaz7722:bug/configuration-delta
May 13, 2026
Merged

Fix incorrect delta comparison for ConfigurationValues#215
ack-prow[bot] merged 1 commit into
aws-controllers-k8s:mainfrom
gustavodiaz7722:bug/configuration-delta

Conversation

@gustavodiaz7722
Copy link
Copy Markdown
Member

Fix incorrect delta comparison for Addon ConfigurationValues

Problem

The EKS controller was performing a simple string comparison on the ConfigurationValues field for Addons. This caused infinite reconciliation loops aws-controllers-k8s/community#2877

Solution

  • Marked ConfigurationValues as is_document: true in generator.yaml, which triggers semantic JSON/YAML comparison via ackcompare.DocumentEqual from the ACK runtime.
  • Updated the runtime dependency to v0.58.2-0.20260512210412-61d58ad3edb8 which includes the DocumentEqual function.

All unit tests pass, covering nil handling, formatting equivalence, and real diff detection.

@ack-prow ack-prow Bot requested review from a-hilaly, jlbutler and sapphirew May 13, 2026 04:45
Copy link
Copy Markdown
Member

@michaelhtm michaelhtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ack-prow ack-prow Bot added lgtm Indicates that a PR is ready to be merged. approved and removed lgtm Indicates that a PR is ready to be merged. labels May 13, 2026
@gustavodiaz7722 gustavodiaz7722 force-pushed the bug/configuration-delta branch from 3d487b1 to 9010892 Compare May 13, 2026 19:43
@ack-prow
Copy link
Copy Markdown

ack-prow Bot commented May 13, 2026

@gustavodiaz7722: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
eks-kind-e2e 3d487b1 link true /test eks-kind-e2e

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gustavodiaz7722
Copy link
Copy Markdown
Member Author

gustavodiaz7722 commented May 13, 2026

/retest

1 similar comment
@gustavodiaz7722
Copy link
Copy Markdown
Member Author

/retest

@michaelhtm
Copy link
Copy Markdown
Member

/lgtm

@ack-prow ack-prow Bot added the lgtm Indicates that a PR is ready to be merged. label May 13, 2026
@ack-prow
Copy link
Copy Markdown

ack-prow Bot commented May 13, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gustavodiaz7722, michaelhtm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow Bot merged commit c100ee3 into aws-controllers-k8s:main May 13, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants