Fix incorrect delta comparison for ConfigurationValues#215
Conversation
3d487b1 to
9010892
Compare
|
@gustavodiaz7722: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest |
1 similar comment
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gustavodiaz7722, michaelhtm The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fix incorrect delta comparison for Addon ConfigurationValues
Problem
The EKS controller was performing a simple string comparison on the
ConfigurationValuesfield for Addons. This caused infinite reconciliation loops aws-controllers-k8s/community#2877Solution
ConfigurationValuesasis_document: trueingenerator.yaml, which triggers semantic JSON/YAML comparison viaackcompare.DocumentEqualfrom the ACK runtime.v0.58.2-0.20260512210412-61d58ad3edb8which includes theDocumentEqualfunction.All unit tests pass, covering nil handling, formatting equivalence, and real diff detection.